feat:User CRUD #35
feat:User CRUD #35
Conversation
There was a problem hiding this comment.
@ergjustin nice work!
A few questions for you, but overall this looks great
|
Related Issues: USER CRUD Except password reset everything else finished. |
There was a problem hiding this comment.
Thanks for all of the updates @ergjustin!
A few issues that we can discuss on our call
| header: 'Admin section', | ||
| items: [ | ||
| { | ||
| can: ['read', 'users'], |
There was a problem hiding this comment.
admin section will still be shown to a standard user in this case.
I believe admin section should be shown to only manager and sys admin
Related to #43
There was a problem hiding this comment.
making a note that we also want this nav section to be hidden when you "drill down" into an Org. And we want to change the name Admin Section => Admin
There was a problem hiding this comment.
admin section will still be shown to standard users (in addition to managers and admins) but perhaps that is our intent
There was a problem hiding this comment.
we discussed today, @ergjustin will make this can -> canCreate
| header: 'Admin section', | ||
| items: [ | ||
| { | ||
| can: ['read', 'users'], |
There was a problem hiding this comment.
admin section will still be shown to standard users (in addition to managers and admins) but perhaps that is our intent
|
I think we are finally good to merge this unless there are other pending issues I'm not aware of |
Related Issues:
USERS CRUD
Resolves #30 #36 #37
Main Changes:
Steps To Test: